Ticket #77 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Include played move in atari-atari blunder analysis

Reported by: arend Owned by: gnugo
Priority: normal Milestone: 3.7.9
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description (last modified by arend) (diff)

The motivation of this patch is strategy5:287:





















The atari-atari analysis didn't find the combination attack after White D1. This turned out to be due to a FIXME in the atari-atari blunder code: The computation of target values didn't include the played move.

This is solved by the attached patch. Two additional changes were necessary:

  • Allow owl_substantial() to be called at stackp != 0.
  • The safety of the recently played move had to be set to 0 in case it depends on ok. (Otherwise atari_atari will just find the ko attack again and report it as combination attack.)

The patch doesn't actually solve strategy5:287 yet, because C2 is overvalued. The breakage is minor but slightly positive:

blunder:17      FAIL T7 [R7]
nngs4:890       PASS B13 [!B18]
ninestones:220  PASS P9 [P9|P8]
Total nodes: 1684174610 3288880 12469192

Attachments

arend_7_9.6.diff Download (3.1 KB) - added by arend 6 years ago.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
arend_7_9.6.diff Download never tested

Change History

Changed 6 years ago by arend

comment:1 Changed 6 years ago by arend

  • patch set

comment:2 Changed 6 years ago by arend

  • Description modified (diff)

comment:3 Changed 6 years ago by arend

  • Status changed from new to closed
  • Resolution set to fixed

comment:4 Changed 6 years ago by gunnar

  • Milestone set to 3.7.9
Note: See TracTickets for help on using tickets.