Ticket #48 (new task)

Opened 3 years ago

Last modified 2 years ago

Reduce the number of negative test results.

Reported by: gunnar Assigned to: gnugo
Priority: normal Milestone: 3.8
Component: regressions Version:
Severity: minor Keywords:
Cc: patch: 1

Description (Last modified by arend)

Many tests have results in negative form ([!...]), allowing any move except one or a few. This has turned out to often be problematic and a frequent source of "regression noise". Therefore most of those tests should be changed. Possible modifications are:

  • Change to restricted_genmove when a specific problem should be addressed or when it's unclear what the globally best move is.
  • Change to a positive result, when the globally acceptable moves can be determined and restricted_genmove is not more appropriate.
  • Remove the test if there's not much point in it.

The current (GNU Go 3.7.8) number of negative test results for different test suites are

56 trevorc.tst
35 trevorb.tst
30 nngs3.tst
29 trevord.tst
22 trevor.tst
16 blunder.tst
12 trevora.tst
11 strategy4.tst
11 nngs4.tst
11 nngs1.tst
10 nngs2.tst
8 arend.tst
7 strategy3.tst
7 ninestones.tst
5 olympiad2004.tst
5 auto03.tst
4 handtalk.tst
4 century2002.tst
4 auto02.tst
3 strategy5.tst
3 strategy.tst
2 strategy2.tst
2 owl.tst
2 nngs.tst
2 nando.tst
2 manyfaces1.tst
2 dniwog.tst
2 buzco.tst
2 auto04.tst
1 semeai.tst
1 manyfaces.tst
1 gifu03.tst
1 ego.tst
1 auto01.tst
1 atari_atari.tst
1 arend2.tst
1 arb.tst
1 9x9.tst
1 13x13b.tst

for a total of 319.

To create this list, do

egrep -c '^#\? \[!' *.tst | grep -v ':0' | tr : ' ' | awk '{print $2 " " $1}' | sort -nr

Attachments

gunnar_7_8.7 (13.6 kB) - added by gunnar on 10/20/05 22:25:23.
Fixes for arb, arion, ego, nicklas1, nicklas5, niki, strategy2, and viking.
gunnar_7_8.9.diff (3.6 kB) - added by gunnar on 10/20/05 23:49:53.
Fixes for gifu03, manyfaces, and strategy.
gunnar_7_8.11.diff (9.8 kB) - added by gunnar on 10/27/05 22:58:39.
Fixes for a few tests each in several files.
arend_7_8.12-negated_test_results_nngs.tst (10.8 kB) - added by arend on 01/28/06 00:10:41.
Fixes for nngs.tst
gunnar_7_9.3.diff (4.2 kB) - added by gunnar on 02/06/06 23:22:54.
Partial fix for trevorc.tst.
gunnar_7_9.9.diff (7.7 kB) - added by gunnar on 02/17/06 22:51:33.
partial fixes for trevorb.tst and nngs1.tst
gunnar_7_10.3.diff (5.4 kB) - added by gunnar on 03/17/06 23:33:15.
Fixes for most of trevora.tst and strategy4.tst

Change History

10/20/05 22:25:23 changed by gunnar

  • attachment gunnar_7_8.7 added.

Fixes for arb, arion, ego, nicklas1, nicklas5, niki, strategy2, and viking.

10/20/05 22:33:41 changed by gunnar

  • description changed.

10/20/05 23:49:53 changed by gunnar

  • attachment gunnar_7_8.9.diff added.

Fixes for gifu03, manyfaces, and strategy.

10/27/05 22:58:39 changed by gunnar

  • attachment gunnar_7_8.11.diff added.

Fixes for a few tests each in several files.

01/27/06 11:35:44 changed by arend

  • patch set to 1.

01/27/06 20:26:10 changed by gunnar

From arend_7_8.12:

+# Not clear what is best, but strengthening one of the weak groups
+# is urgent. /ab
 loadsgf games/nngs/AdaGeek-gnugo-3.1.18-200201071333.sgf 24
 230 reg_genmove black
-#? [!F7]
+#? [E9|G7|H2|K6|N4|D6]

N4 should be N5?

01/28/06 00:10:41 changed by arend

  • attachment arend_7_8.12-negated_test_results_nngs.tst added.

Fixes for nngs.tst

01/28/06 00:11:55 changed by arend

Right about nngs:230, patch is updated.

02/06/06 23:22:54 changed by gunnar

  • attachment gunnar_7_9.3.diff added.

Partial fix for trevorc.tst.

02/09/06 18:42:30 changed by arend

  • description changed.

Updated current "high score list".

02/17/06 22:51:33 changed by gunnar

  • attachment gunnar_7_9.9.diff added.

partial fixes for trevorb.tst and nngs1.tst

03/17/06 23:33:15 changed by gunnar

  • attachment gunnar_7_10.3.diff added.

Fixes for most of trevora.tst and strategy4.tst