Ticket #45 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

VC++ build repair

Reported by: nando Owned by: gnugo
Priority: normal Milestone: 3.7.8
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description

With the few appended changes, GNU Go builds cleanly with VC++.

Attachments

nando_7_8.3.diff Download (841 bytes) - added by nando 6 years ago.
READLINE is always 'defined', and sometimes (with VC++ for instance) it is set to 0
readline_configure_7_8.1.diff Download (8.0 KB) - added by arend 6 years ago.
#define READLINE to 0 instead of leaving it undefined

Regression Results

Attachment Rev. PASS FAIL Nodes Status
nando_7_8.3.diff Download never tested
readline_configure_7_8.1.diff Download never tested

Change History

Changed 6 years ago by nando

READLINE is always 'defined', and sometimes (with VC++ for instance) it is set to 0

comment:1 Changed 6 years ago by arend

This will cause warnings on other platforms, since by default READLINE is just undefined. We have to fix this one way (not defining READLINE for VC++) or another (defining READLINE to 0 by default, which would be the normal GNU Go practice).

Changed 6 years ago by arend

#define READLINE to 0 instead of leaving it undefined

comment:2 Changed 6 years ago by arend

I suggest to use the attached readline_configure_7.8.1.diff in addition to nando_7_8.3.diff.

comment:3 Changed 6 years ago by arend

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.