Ticket #31 (closed task: fixed)

Opened 3 years ago

Last modified 3 years ago

Only use plain "char" for (text) strings

Reported by: gunnar Assigned to: gnugo
Priority: normal Milestone: 3.7.7
Component: source Version:
Severity: normal Keywords:
Cc: patch: 1

Description

Using the "char" type is dangerous because the compiler is free to treat it as signed or unsigned. This has caused a number of bugs over time. To solve this problem permanently we need to use "char" only for (text) strings and otherwise "signed char" and "unsigned char".

Attachments

signed_char_7_7.2 (31.6 kB) - added by arend on 10/07/05 08:51:25.
More consistent try to convert influence code + callers + combination code + callers to signed char
signed_char_7_7.3 (9.0 kB) - added by arend on 10/07/05 09:05:01.
Convert breakin code + callers to use signed char
signed_char_7_7.4 (16.8 kB) - added by arend on 10/07/05 09:25:42.
Convert matchpat and owl code to use signed char
signed_char_7_7.5 (11.5 kB) - added by arend on 10/07/05 23:29:04.
Convert various markings, goals etc. to be signed char
signed_char_7_7.6 (7.6 kB) - added by arend on 10/07/05 23:35:49.
Remove signed_mark_string()
signed_char_7_7.7 (3.3 kB) - added by arend on 10/08/05 10:32:45.
some tidbits missed earlier
signed_char_7_7.8 (5.4 kB) - added by gunnar on 10/09/05 21:07:26.
signed_char_7_7.9 (1.3 kB) - added by gunnar on 10/09/05 21:57:01.
A few more missed variables.

Change History

10/07/05 08:51:25 changed by arend

  • attachment signed_char_7_7.2 added.

More consistent try to convert influence code + callers + combination code + callers to signed char

10/07/05 09:05:01 changed by arend

  • attachment signed_char_7_7.3 added.

Convert breakin code + callers to use signed char

10/07/05 09:25:42 changed by arend

  • attachment signed_char_7_7.4 added.

Convert matchpat and owl code to use signed char

10/07/05 23:29:04 changed by arend

  • attachment signed_char_7_7.5 added.

Convert various markings, goals etc. to be signed char

10/07/05 23:35:49 changed by arend

  • attachment signed_char_7_7.6 added.

Remove signed_mark_string()

10/07/05 23:41:33 changed by arend

  • patch set to 1.
  • milestone changed from 3.8 to 3.7.7.

10/08/05 10:32:45 changed by arend

  • attachment signed_char_7_7.7 added.

some tidbits missed earlier

10/09/05 21:07:26 changed by gunnar

  • attachment signed_char_7_7.8 added.

10/09/05 21:57:01 changed by gunnar

  • attachment signed_char_7_7.9 added.

A few more missed variables.

10/09/05 22:13:50 changed by gunnar

  • status changed from new to closed.
  • resolution set to fixed.