Ticket #31 (closed task: fixed)
Only use plain "char" for (text) strings
| Reported by: | gunnar | Owned by: | gnugo |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.7.7 |
| Component: | source | Version: | |
| Severity: | normal | Keywords: | |
| Cc: | patch: | yes |
Description
Using the "char" type is dangerous because the compiler is free to treat it as signed or unsigned. This has caused a number of bugs over time. To solve this problem permanently we need to use "char" only for (text) strings and otherwise "signed char" and "unsigned char".
Attachments
-
signed_char_7_7.2
(31.6 KB) - added by arend
5 years ago.
- More consistent try to convert influence code + callers + combination code + callers to signed char
-
signed_char_7_7.3
(9.0 KB) - added by arend
5 years ago.
- Convert breakin code + callers to use signed char
-
signed_char_7_7.4
(16.8 KB) - added by arend
5 years ago.
- Convert matchpat and owl code to use signed char
-
signed_char_7_7.5
(11.5 KB) - added by arend
5 years ago.
- Convert various markings, goals etc. to be signed char
-
signed_char_7_7.6
(7.6 KB) - added by arend
5 years ago.
- Remove signed_mark_string()
-
signed_char_7_7.7
(3.3 KB) - added by arend
5 years ago.
- some tidbits missed earlier
-
signed_char_7_7.8
(5.4 KB) - added by gunnar
5 years ago.
-
signed_char_7_7.9
(1.3 KB) - added by gunnar
5 years ago.
- A few more missed variables.
Regression Results
| Attachment | Rev. | PASS | FAIL | Nodes | Status |
Change History
Note: See
TracTickets for help on using
tickets.
