Ticket #212 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

Don't crash if gtp_aa_confirm_safety is fed an illegal move

Reported by: bump Owned by: gnugo
Priority: normal Milestone: 3.9.1
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description (last modified by gunnar) (diff)

see
 http://lists.gnu.org/archive/html/gnugo-devel/2009-02/msg00000.html
 http://lists.gnu.org/archive/html/gnugo-devel/2009-02/msg00003.html
and thread for details

Attachments

0001-don-t-crash-if-gtp_aa_confirm_safety-is-fed-an-illeg.patch Download (1017 bytes) - added by bump 3 years ago.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
0001-don-t-crash-if-gtp_aa_confirm_safety-is-fed-an-illeg.patch Download never tested

Change History

comment:1 Changed 3 years ago by gunnar

  • patch set
  • Description modified (diff)
  • Milestone changed from 3.9.x to 3.9.1

This patch is not good since it leaves the stone played if the move is legal, promptly causing the reported assertion failure, but now for the valid moves. An else popgo() should solve the problem.

Changed 3 years ago by bump

comment:2 Changed 3 years ago by bump

replaced attachment. added popgo()

comment:3 Changed 2 years ago by gunnar

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.