Ticket #196 (closed enhancement: fixed)

Opened 9 months ago

Last modified 9 months ago

move send_two_return_one to board library

Reported by: gunnar Owned by: gnugo
Priority: normal Milestone: 3.7.12
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description

This patch moves the send_two_return_one() function from utils.c to board.c and implements it as a low level board function. This has two implications:

  1. It becomes faster. This is probably not critical but since it's called from the tactical reading it can't hurt.
  2. More importantly, the tactical reading sgf dumps are no longer cluttered by uninteresting trymoves from this function after a ko capture.

Attachments

gunnar_7_12.4.diff (4.9 kB) - added by gunnar 9 months ago.
Turn send_two_return_one() into a low level board function.
gunnar_7_12.4b.diff (5.0 kB) - added by gunnar 9 months ago.
Second attempt.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
gunnar_7_12.4.diff 2401 2 +0.046% +0.065% -0.011% details
gunnar_7_12.4b.diff 2407 -0.0075% -0.00075% -0.00026% builds with warning(s) details

Change History

Changed 9 months ago by gunnar

Turn send_two_return_one() into a low level board function.

Changed 9 months ago by gunnar

Second attempt.

Changed 9 months ago by gunnar

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.