Ticket #168 (closed enhancement: fixed)

Opened 18 months ago

Last modified 11 months ago

send_two_return_one upgrade and usage in ATTACK_TRY_MOVES

Reported by: draqo Owned by: gnugo
Priority: low Milestone: 3.7.11
Component: source Version:
Severity: normal Keywords: send_two_return_one ATTACK_TRY_MOVES
Cc: patch: yes

Description

Added checking if move is not send_two_return_one type before trying moves in ATTACK_TRY_MOVES. Also send_two_return_one upgrade to: not filter out some valuable moves and speed enhancement.

Attachments

send2ret1.patch (3.3 kB) - added by draqo 18 months ago.
draqo-send2ret1.diff (2.8 kB) - added by gunnar 16 months ago.
Rediffed and lightly modified patch.
draqo-send2ret1a.diff (2.1 kB) - added by gunnar 11 months ago.
One part of the patch.
draqo-send2ret1b.diff (0.7 kB) - added by gunnar 11 months ago.
The other part of the patch.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
draqo-send2ret1.diff 2385 -0.14% +0.014% -0.0038% details
2388 -0.14% +0.0046% -0.0039% details
draqo-send2ret1a.diff 2391 0% 0% 0% details
draqo-send2ret1b.diff 2391 -0.13% +0.0053% -0.0036% details
send2ret1.patch 2381 patch does not apply details
2382 patch does not apply details

Change History

Changed 18 months ago by draqo

Changed 18 months ago by draqo

Look for comment from 03/07/07 14:15:46 in ticket 148 for regression discussion of this ticket.

Changed 16 months ago by gunnar

Rediffed and lightly modified patch.

Changed 11 months ago by gunnar

One part of the patch.

Changed 11 months ago by gunnar

The other part of the patch.

Changed 11 months ago by gunnar

Out of curiousity I'd like to see how this patch does on regressions when split into two separate parts which can be used independently.

Changed 11 months ago by gunnar

It turns out that draqo-send2ret1a.diff has no effect at all.

That is due to this code 

  /* The move to capture back is in lib2. This must be one of the two
   * captured stones, either the move or the adjacent stone. If it is
   * the same as the first move, the previous position is not repeated
   * by capturing back, so we return false.
   */
  if (lib2 == move)
    return 0;

near the end of the function which checks for exactly the same situation.

Changed 11 months ago by gunnar

  • status changed from new to closed
  • resolution set to fixed

draqo-send2ret1b.diff has been added to CVS.

Note: See TracTickets for help on using tickets.