Ticket #168 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

send_two_return_one upgrade and usage in ATTACK_TRY_MOVES

Reported by: draqo Owned by: gnugo
Priority: low Milestone: 3.7.11
Component: source Version:
Severity: normal Keywords: send_two_return_one ATTACK_TRY_MOVES
Cc: patch: yes

Description

Added checking if move is not send_two_return_one type before trying moves in ATTACK_TRY_MOVES. Also send_two_return_one upgrade to: not filter out some valuable moves and speed enhancement.

Attachments

send2ret1.patch Download (3.3 KB) - added by draqo 5 years ago.
draqo-send2ret1.diff Download (2.8 KB) - added by gunnar 5 years ago.
Rediffed and lightly modified patch.
draqo-send2ret1a.diff Download (2.1 KB) - added by gunnar 4 years ago.
One part of the patch.
draqo-send2ret1b.diff Download (688 bytes) - added by gunnar 4 years ago.
The other part of the patch.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
draqo-send2ret1.diff Download 2385 -0.14% +0.014% -0.0038% details
2388 -0.14% +0.0046% -0.0039% details
draqo-send2ret1a.diff Download 2391 0% 0% 0% details
draqo-send2ret1b.diff Download 2391 -0.13% +0.0053% -0.0036% details
send2ret1.patch Download 2381 patch does not apply details
2382 patch does not apply details

Change History

Changed 5 years ago by draqo

comment:1 Changed 5 years ago by draqo

Look for comment from 03/07/07 14:15:46 in ticket 148 for regression discussion of this ticket.

Changed 5 years ago by gunnar

Rediffed and lightly modified patch.

Changed 4 years ago by gunnar

One part of the patch.

Changed 4 years ago by gunnar

The other part of the patch.

comment:2 Changed 4 years ago by gunnar

Out of curiousity I'd like to see how this patch does on regressions when split into two separate parts which can be used independently.

comment:3 Changed 4 years ago by gunnar

It turns out that draqo-send2ret1a.diff Download has no effect at all.

That is due to this code 

  /* The move to capture back is in lib2. This must be one of the two
   * captured stones, either the move or the adjacent stone. If it is
   * the same as the first move, the previous position is not repeated
   * by capturing back, so we return false.
   */
  if (lib2 == move)
    return 0;

near the end of the function which checks for exactly the same situation.

comment:4 Changed 4 years ago by gunnar

  • Status changed from new to closed
  • Resolution set to fixed

draqo-send2ret1b.diff Download has been added to CVS.

Note: See TracTickets for help on using tickets.