Ticket #167 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Small semeai revisions

Reported by: nando Owned by: gnugo
Priority: low Milestone: 3.7.11
Component: source Version:
Severity: minor Keywords:
Cc: patch: yes

Description

A simple idea: if we aren't going to use shape_offensive_moves, maybe shouldn't we look for them in the first place.

The breakage is neutral, but not as neutral as one would expect. Due to the nature of the change, a variation in the number of OWL nodes appears at first as not very logical. But we know by experience that the persistent reading cache may at times induce such effects. I'm confident it's the case here, but if someone insists on getting proof of that, I'll try to find time to dig deeper.

Total nodes: 1697336351(-0.6%) 3336337(+eps) 12311921(-1.4%)

The other change is a typo-fix in the second call to get_next_move_from_list(). The owl parameter was wrong. This has no consequences, since cuts aren't used currently within the semai code.

Attachments

semeai_7_11.1.diff Download (1.1 KB) - added by nando 3 years ago.
Minor semeai code revisions

Regression Results

Attachment Rev. PASS FAIL Nodes Status
semeai_7_11.1.diff Download never tested

Change History

Changed 3 years ago by nando

Minor semeai code revisions

in reply to: ↑ description   Changed 3 years ago by gunnar

Replying to nando:

The breakage is neutral, but not as neutral as one would expect. Due to the nature of the change, a variation in the number of OWL nodes appears at first as not very logical. But we know by experience that the persistent reading cache may at times induce such effects. I'm confident it's the case here, but if someone insists on getting proof of that, I'll try to find time to dig deeper.

Don't bother digging into this. The patch looks fine, and gives a nice reduction of nodes.

  Changed 3 years ago by nando

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.