Ticket #164 (new enhancement)

Opened 4 years ago

Last modified 18 months ago

Defend both function upgrade

Reported by: draqo Owned by: gnugo
Priority: normal Milestone: Future
Component: source Version:
Severity: normal Keywords: defend_both
Cc: patch: yes

Description

I upgraded defend_both to return ko results too (previously it returned only WIN or LOSE). This required changing all defend_both calls to recognize new returned values. Because there are hundreds of them I didn't check all of them, which change from !=LOSE / ==LOSE / !=WIN / ==WIN set is the best for them. Now all !defend_both are changed to defend_both == LOSE and defend_both to defend_both == WIN (except one - pattern CC505 from ticket 163).

Attachments

def_both.diff Download (29.7 KB) - added by draqo 4 years ago.
def_botha.diff Download (32.2 KB) - added by arend 3 years ago.
Same patch as def_both.diff, rediffed.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
def_both.diff Download 2381 patch does not apply details
2382 patch does not apply details
def_botha.diff Download 2382 1 +0.13% +0.032% +0.03% details

Change History

Changed 4 years ago by draqo

Changed 4 years ago by draqo

Look for comment from 01/23/07 00:19:53 in ticket 148 for regression description of this ticket.

Changed 3 years ago by arend

Same patch as def_both.diff, rediffed.

Changed 3 years ago by gunnar

  • milestone changed from 3.7.11 to 3.8

Changed 18 months ago by gunnar

  • milestone changed from 3.8 to Future
Note: See TracTickets for help on using tickets.