minor display bug with -T and TERMINFO

[alain]

Viewing the attached screenshot may help ;-)

With -T, in a white foreground xterm (or konsole or rxvt), after the first stone on the board, the foreground color is not reset to original value (black) but instead is light-grey.

In gg_utils, this correspond to the fputs (line 159)

void 
write_color_char_no_space(int c, int x)
{
#ifdef TERMINFO

  fprintf(stderr, "%s%c", tparm(setaf, c, 0, 0, 0, 0, 0, 0, 0, 0), x);
  fputs(tparm(setaf, max_color, 0, 0, 0, 0, 0, 0, 0, 0), stderr);

#elif 

[alain]

screnshot

[gunnar]

I'm kind of more inclined to remove the colored displays altogether, but if someone actually uses them I suppose they could stay.

I don't know anything about terminfo. Is it max_color that happens to indicate light-gray and is there any more appropriate value?

[nando]

Replying to gunnar:

I'm kind of more inclined to remove the colored displays altogether, but if someone actually uses them I suppose they could stay.

FWIW, I do, quite often actually.

[josephpiche]

I am also in favor of keeping the colors. After looking at the source of utils/gg_utils.c and compiling gnugo with config options TERMINFO 0 and ANSI_COLOR 1, it still occurs.

[josephpiche]

My mistake, the ansi color does work. Compiling with "--without-curses" and "--enable-color" gives a working -T on a white background.

One possible solution is to disable ncurses altogether and only use ansi color. I see no problem with this, as it also would remove a dependency of compiling gnugo, but if someone has some objection to this I can continue to look at it and try to fix it.

[gunnar]

We once had a debugboard utility using ncurses but it has long been retired and eventually completely removed. But ncurses use for colors predated that utility so I assume it was introduced specifically to support colored displays.

I'm all for removing the ncurses dependency if it's not needed.

[josephpiche]

potential fix

[josephpiche]

I haven't done many patches before, so I'm not quite sure if this will work. Plus, I excluded changes to files make by autoconf, as I'm not sure I have the right version or am running the command correctly.

[josephpiche]

A better patch that actually fixes the terminfo code

[gunnar]

The patch looks very good. I've added it to CVS now.