Ticket #149 (closed enhancement: fixed)

Opened 5 years ago

Last modified 5 years ago

tiny pattern tuning (endgame and patterns2)

Reported by: alain Owned by: gnugo
Priority: normal Milestone: 3.7.11
Component: patterns Version:
Severity: normal Keywords:
Cc: patch: yes

Description

Remove CF3 redondant and broken pattern in endgame.db => 1 PASS
Fix some symetry in endgame.db and patterns2.db

nngs:308        PASS L3 [L3|M19]
Total nodes: 1691662016 3342344 12622102
Total uncertainty: 47.59
1 PASS

Attachments

patterns2-endgame.diff Download (3.7 KB) - added by alain 5 years ago.
diff -u6 for easier check of the patch
al_3_7_10.1b Download (3.8 KB) - added by gunnar 5 years ago.
Stylistic fixes.

Regression Results

Attachment Rev. PASS FAIL Nodes Status
patterns2-endgame.diff Download never tested

Change History

comment:1 follow-up: ↓ 2 Changed 5 years ago by alain

bogus display of the patch in trac! There are 2 files, the last one is not shown :(

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 5 years ago by nando

Replying to alain:

bogus display of the patch in trac! There are 2 files, the last one is not shown :(

Maybe you better do a diff against CVS (cvs diff -u). I guess, the display is bogus, because of the missing "Index: ..." lines.

comment:3 in reply to: ↑ 2 Changed 5 years ago by alain

Replying to nando:

Replying to alain:

bogus display of the patch in trac! There are 2 files, the last one is not shown :(

Maybe you better do a diff against CVS (cvs diff -u). I guess, the display is bogus, because of the missing "Index: ..." lines.

Yes, that's it. :) everything ok now.

Changed 5 years ago by alain

diff -u6 for easier check of the patch

comment:4 Changed 5 years ago by nando

Glad it worked. Now a few comments :

  • pattern commentars usually follow the Pattern XXX line and, if it only fixed the symmetry, then it says just that (keeping the previous setting isn't very helpful)
  • an exception to the above rule: pattern removal notices usually precede the Pattern XXX line
  • the SenteXXX pattern class is by convention about moves which are either sente or reverse-sente. Personally, I have no problem with RevSenteXXX names (doesn't change a thing), but there might be (possibly good) reasons to keep it the way it is. Unless you have a more specific reason to introduce a new naming convention, maybe it's better to stick to the old one...

comment:5 Changed 5 years ago by arend

  • Status changed from new to closed
  • Resolution set to fixed

Changed 5 years ago by gunnar

Stylistic fixes.

comment:6 Changed 5 years ago by gunnar

  • Component changed from source to patterns

The attached patch al_3_7.10b makes the pattern comments follow the usual style. I also reverted the name change RevSente13. Just changing the name of one of the reverse sente patterns is meaningless and I don't see much gain in doing it consistently either. The comment for that class of patterns does say that it applies for both sente and reverse sente patterns.

Note: See TracTickets for help on using tickets.