Ticket #141 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Bugfix in owl.c

Reported by: nando Owned by: gnugo
Priority: normal Milestone: 3.7.11
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description

I was actually about to call this a simple enhancement rather than a bugfix, since it only prevents some cluttering of the SGF output. But the node counts changes 

Total nodes: 1691326785 3342291 12618862
Total time: 7849.60 (7856.47)
Total uncertainty: 46.88

... suggest that it could have an actual influence on move generation (although it didn't in the regression run)

-- nando

Attachments

bugfix_7_11.5.diff Download (883 bytes) - added by arend 5 years ago.
(Only file name changed) Fixes node counting in semeai reading

Regression Results

Attachment Rev. PASS FAIL Nodes Status
bugfix_7_11.5.diff Download never tested

Change History

comment:1 Changed 5 years ago by gunnar

Seems weird that it should affect the node count. Might be worth investigating.

comment:2 Changed 5 years ago by nando

You're right, it's weird. I'm going to dig a bit deeper...

comment:3 Changed 5 years ago by nando

Ok, got it.

The semeai code in owl.c sometimes calls do_owl_attack(). Without the patch, the global variable count_variations may get incremented more than it actually should. But since OWL checks its node limits by (among others) comparing local_owl_node_counter to owl_node_limit, it doesn't matter.

Additionally, the semeai code checks its node count limits by comparing a certain node count variable to the semeai_node_limit one. And that node count global variable name is ...

Time for a local_semeai_node_counter ?

Changed 5 years ago by arend

(Only file name changed) Fixes node counting in semeai reading

comment:4 Changed 5 years ago by arend

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.