Ticket #139 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Bugfix in surround.c

Reported by: nando Owned by: gnugo
Priority: normal Milestone: 3.7.11
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description

The appended patch fixes a conceptual bug I introduced a long time ago in the surround code. Under circumstances, dragons which should have been cataloged as "not surrounded" were actually still considered as "weakly surrounded".

The breakage is neutral, 1 PASS and 1 FAIL. 

trevor:220      PASS E8 [E8]
strategy4:190   FAIL E7 [D13]

I just can say that the failure is definitely not a problem with the bugfix itself.

Other than that, these are the counters I'm getting with my Linux box: 

Total nodes: 1691312768 3342139 12618757
Total time: 7832.19 (7840.57)
Total uncertainty: 46.88
1 PASS
1 FAIL

-- nando

Attachments

bugfix_7_11.2.diff Download (768 bytes) - added by nando 5 years ago.
Bugfix in compute_surroundings()
bugfix_7_11.2a.diff Download (899 bytes) - added by nando 5 years ago.
Patch revised according to Gunnar's comment

Regression Results

Attachment Rev. PASS FAIL Nodes Status
bugfix_7_11.2.diff Download never tested
bugfix_7_11.2a.diff Download never tested

Change History

Changed 5 years ago by nando

Bugfix in compute_surroundings()

comment:1 Changed 5 years ago by gunnar

Clearly a bugfix, indeed. It might be simpler to do that board loop in 1D instead of 2D though.

Changed 5 years ago by nando

Patch revised according to Gunnar's comment

comment:2 Changed 5 years ago by nando

Certainly, patch revised accordingly.

comment:3 Changed 5 years ago by gunnar

  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.