Ticket #130 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

bug in configure/make: gcc warns with --disable-socket-support

Reported by: aquarius (kautz@… Owned by: gnugo
Priority: normal Milestone: 3.7.10
Component: source Version:
Severity: trivial Keywords: configure make
Cc: patch: no

Description

If one configures GNU Go with --disable-socket-support, gcc will emit warnings but will compile anyway. (Tested on WinXP with GNU mingw/msys, result: working binary whithout sockets)

No clue what will happen on linux/unix.

cause: ENABLE_SOCKET_SUPPORT is #define-d or #undef-ined in configure but tested using #if in interface/main.c .

possible solution: Either make ENABLE_SOCKET_SUPPORT take value 1/0 in configure or use #ifdef in interface/main.c .

... I wonder if this is the only --disable...option in configure where this bug occures, but I didn't take the time to look or try.

Change History

comment:1 Changed 6 years ago by aquarius

  • Summary changed from bug in configure/make (trivial): gcc warns with --disable-socket-support to bug in configure/make: gcc warns with --disable-socket-support

comment:2 Changed 6 years ago by gunnar

  • Status changed from new to closed
  • Resolution set to fixed

"#ifdef ENABLE_SOCKET_SUPPORT" is now used in interface/main.c instead of #if, fixed directly in the repository.

Note: See TracTickets for help on using tickets.