Ticket #129 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

configure bug: socket support not detected with gcc/mingw on WinXP

Reported by: aquarius (kautz@… Owned by: gnugo
Priority: normal Milestone: 3.7.10
Component: source Version:
Severity: trivial Keywords: configure mingw socket
Cc: patch: yes

Description (last modified by aquarius) (diff)

GNU Go compiles well on WinXP with socket support enabled but configure will not switch it on - you have to hack config.h if you want it.

Found on WinXP with GNU mingw/msys/gcc. I bet that cygwin is also affected. No clue about VC build process.

Possible solution: If the config test for unix sockets should fail, just run a config test that resembles the WINxy part of the #ifdef magic in interface/main.c .

Things turned out to be even simpler: Three more lines in the existing test make it work on mingw/msys.

See attached patch for configure.in.

Attachments

configure.in.diff Download (567 bytes) - added by aquarius (kautz@… 6 years ago.
include winsock.h in config test for socket support makes it work with mingw/cygwin builds

Regression Results

Attachment Rev. PASS FAIL Nodes Status
configure.in.diff Download never tested

Change History

comment:1 Changed 6 years ago by aquarius

  • Summary changed from configure bug (trivial): socket support not usable with gcc/mingw on WinXP to configure bug: socket support not usable with gcc/mingw on WinXP

comment:2 Changed 6 years ago by aquarius (kautz@…

  • Summary changed from configure bug: socket support not usable with gcc/mingw on WinXP to configure bug: socket support not detected with gcc/mingw on WinXP
  • patch set

Things turned out to be even simpler: Three more lines in the existing test make it work on mingw/msys.

See attached patch for configure.in.

comment:3 Changed 6 years ago by aquarius

  • Description modified (diff)

Changed 6 years ago by aquarius (kautz@…

include winsock.h in config test for socket support makes it work with mingw/cygwin builds

comment:4 Changed 6 years ago by aquarius

  • Status changed from new to closed
  • Resolution set to worksforme

comment:5 Changed 6 years ago by gunnar

  • Status changed from closed to reopened
  • Resolution worksforme deleted

The purpose of worksforme is to mark tickets with unreproducible bugs or misunderstood non-bugs. I'm reopening this ticket, it will be closed as fixed when the patch has been added to the repository.

comment:6 Changed 6 years ago by gunnar

  • Status changed from reopened to closed
  • Resolution set to fixed

Now the patch has been added. Thanks for providing it.

Note: See TracTickets for help on using tickets.