Ticket #121 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

gnugo-3.7.9 --replay white 33990.sgf -o 33990-r379.sgf produces a broken sgf file

Reported by: alain Owned by: gnugo
Priority: normal Milestone: 3.7.10
Component: source Version:
Severity: normal Keywords:
Cc: patch: yes

Description

A (bad) game played on CGOS.
sgfc and cgoban say the 33990.sgf file is valid.

$ sgfc 33990.sgf
33990.sgf: OK

$ gnugo-3.7.9-ref --replay white 33990.sgf -o 33990-replay-379.sgf
$ sgfc 33990-replay-379.sgf
Line:34 Col:52 - Error 14: illegal <CR> value deleted: [``]
Line:35 Col:58 - Error 14: illegal <CR> value deleted: [``]
Line:37 Col:3 - Error 14: illegal <CR> value deleted: [``]
Line:38 Col:3 - Error 14: illegal <CR> value deleted: [``]
Line:44 Col:3 - Error 14: illegal <CR> value deleted: [``]
33990-replay-379.sgf: 5 error(s)

The original game was played with --capture-all-dead. If using this option during the replay, everything is ok.

Attachments

33990.sgf (0.8 kB) - added by alain 2 years ago.
gunnar_7_10.6.diff (509 bytes) - added by gunnar 2 years ago.
Bugfix

Regression Results

Attachment Rev. PASS FAIL Nodes Status
gunnar_7_10.6.diff never tested

Change History

Changed 2 years ago by alain

Changed 2 years ago by gunnar

To clarify the problem, part of the output file looks like

C[GNU Go plays Pass (0.00) - Game move J2 (0.00)]CR[``];B[hb]
;W[hh]C[GNU Go plays Pass (0.00) - Game move H2 (0.00)]CR[``]
;B[ca];W[di]C[GNU Go plays Pass (0.00) - Game move D1 (0.00)]
CR[``];B[db];W[eh]C[GNU Go plays Pass (0.00) - Game move E2 (0.00)]
CR[``];B[fc];W[]C[GNU Go plays the same move Pass (0.00)];B[ga]

where the CR properties are invalid.

Changed 2 years ago by gunnar

Bugfix

Changed 2 years ago by gunnar

  • patch set
  • milestone changed from 3.8 to 3.7.10

Straightforward to solve, see attached patch.

Changed 2 years ago by gunnar

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.