Ticket #161: gunnar_7_11.5b.diff

engine/combination.c

@@ -409 +409 @@
   memset(forbidden, 0, sizeof(forbidden));
   memset(defense_points, 0, sizeof(defense_points));
 
+  compute_aa_status(other, safe_stones);
+  compute_aa_values(other);
+
   /* Accept illegal ko capture here. */
   if (!tryko(move, color, NULL))
     /* Really shouldn't happen. */
     abortgo(__FILE__, __LINE__, "trymove", move);
 
-  compute_aa_status(other, safe_stones);
-  compute_aa_values(other);
-
   increase_depth_values();
 
   aa_val = do_atari_atari(other, &apos, &defense_point, defense_points,
@@ -519 +519 @@
 
 /* Helper function for computing the aa_status for all opponent's strings.
  * If safe_stones is given, we just copy the information from there.
+ * If called at stackp > 0, safe_stones must be provided since the
+ * dragon_data is not valid then.
  */
 
 static void
@@ -529 +531 @@
   SGFTree *save_sgf_dumptree = sgf_dumptree;
   int save_count_variations = count_variations;
   int save_verbose = verbose;
+
+  gg_assert(safe_stones || stackp == 0);
+  
   sgf_dumptree = NULL;
   count_variations = 0;
   if (verbose)
@@ -573 +578 @@
    */
   for (pos = BOARDMIN; pos < BOARDMAX; pos++) {
     if (board[pos] == other
-        && worm[pos].origin == pos
-        && worm[pos].liberties == 2
+        && find_origin(pos) == pos
+        && countlib(pos) == 2
         && aa_status[pos] == ALIVE) {
       int libs[2];
       findlib(pos, 2, libs);
@@ -588 +593 @@
       if (!owl_substantial(pos)) {
         int pos2;
         for (pos2 = BOARDMIN; pos2 < BOARDMAX; pos2++)
-          if (ON_BOARD(pos2) && is_worm_origin(pos2, pos))
+          if (board[pos2] == other && find_origin(pos2) == pos)
             aa_status[pos2] = INSUBSTANTIAL;
       }
     }

regression/9x9.tst

@@ -341 +341 @@
 loadsgf games/cgos/390115.sgf 28
 670 reg_genmove white
 #? [E7]
+
+# There's actually nothing difficult with this position, it's only
+# necessary to avoid a few obvious blunders. The real reason for this
+# test is that a fix for an atari-atari problem introduced a crash in
+# this position. Fixing the crash instead reintroduced an atari-atari
+# mistake in ninestones:220. Let's make sure we won't get a crash here
+# once more. See also tickets #77 and #161.
+loadsgf games/atari-crash.sgf
+680 reg_genmove white
+#? [H7]

regression/ninestones.tst

@@ -64 +64 @@
 190 owl_defend J9
 #? [0]*
 
+# See also 9x9:680 and tickets #77 and #161.
 loadsgf games/nngs/thor-gnugo-3.3.12-200212170003.sgf 108
 220 reg_genmove black
 #? [P9|P8]

new file regression/games/atari-crash.sgf

@@ +1 @@
+(;GM[1]FF[4]SZ[9]KM[7.5]HA[0]GN[GNU Go 3.7.10 stepped on a bug]
+;B[ec];W[ee];B[cf];W[dd];B[dc];W[cd];B[ge];W[eg];B[gg];W[be];B[eh];W[dg]
+;B[fh];W[cc];B[dh];W[cg];B[fd];W[cb];B[ch];W[fa];B[bg];W[bf];B[ed];W[bh]
+;B[gf];W[gc];B[eb];W[ea];B[da];W[gb];B[db];W[hd];B[gd];W[he];B[hf];W[bi]
+;B[ie];W[ic];B[hb];W[ha];B[ib];W[fb];B[ef];W[df];B[if];W[ca];B[de];W[ff]
+;B[fg];W[ce];B[ac];W[fe];B[ab];W[ad];B[aa];W[ci];B[ah];W[di];B[ag];W[af]
+;B[fi];W[ai];B[ag];W[bg];B[ei]
+)